Climatological op #290
Merged
Climatological op #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and stride (formerly 'interval')
…matologicalMean adjusted to reflect minor changes in long_name, description, history
…me to output; all tests pass
…tors_for_available_vars Branch is behind main.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
### Pull Request Checklist:
- [ ] This PR addresses an already opened issue (for bug fixes /
features)
- This PR fixes #xyz
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] (If applicable) Tests have been added.
- [x] This PR does not seem to break the templates.
- [x] CHANGES.rst has been updated (with summary of main changes).
- [x] Link to pull request (:pull:`number`) has been added.
### What kind of change does this PR introduce?
Adds the function `xscen.indicators.select_inds_for_avail_vars` to
filter the indicators that can be calculated with the variables
available in a `xarray.Dataset`.
### Does this PR introduce a breaking change?
No.
### Other information:
…climatological_op
RondeauG
reviewed
Dec 5, 2023
1 task
RondeauG
reviewed
Dec 8, 2023
RondeauG
reviewed
Dec 8, 2023
…n produce_horizon
…s.utils.unstack_dates working
…climatological_op
…omment in test_aggregate.py
…climatological_op
RondeauG
approved these changes
Dec 18, 2023
| "- The `cat:frequency` and `cat:xrfreq` attributes remain unchanged.\n", | ||
| "\n", | ||
| "\n", | ||
| "Alternatively, setting the `horizons_as_dim` argument to *True* will rearrange the dataset with a new dimension `period` and a dimension named according to the temporal aggregation (`year`, `season` or `month`). The time stamps are conserved in the `time` coordinate as an array with those two new dimensions." |
There was a problem hiding this comment.
Suggested change
| "Alternatively, setting the `horizons_as_dim` argument to *True* will rearrange the dataset with a new dimension `period` and a dimension named according to the temporal aggregation (`year`, `season` or `month`). The time stamps are conserved in the `time` coordinate as an array with those two new dimensions." | |
| "Alternatively, setting the `horizons_as_dim` argument to *True* will rearrange the dataset with a new dimension `horizon` and a dimension named according to the temporal aggregation (`year`, `season` or `month`). The time stamps are conserved in the `time` coordinate as an array with those two new dimensions." |
There was a problem hiding this comment.
and a dimension named according to the temporal aggregation (year, seasonormonth)
If year has been removed, it would need to be removed here too.
xscen/aggregate.py
Outdated
| else: | ||
| op_kwargs = { | ||
| "keep_attrs": True | ||
| } # ToDo: Is there a global setting in xscen so we don't need this? |
There was a problem hiding this comment.
I think that calling with xr.set_options(keep_attrs=True): would work in a workflow.
This is something we discussed a while ago, and having a blanket statement for keep_attrs=True would probably not be advised. It's better to do it as needed, such as here.
Suggested change
| } # ToDo: Is there a global setting in xscen so we don't need this? | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
xscen.aggregate.climatological_mean is replaced by xscen.aggregate.climatological_op.
climatological_op permits to apply operations ('op') other than 'mean' to the input dataset.
operations implemented: ['max', 'mean', 'median', 'min', 'std', 'sum', 'var', 'linregress']
other additions:
Modifiede the "Getting Started" notebook to use climatological_op with option 'mean'.
Does this PR introduce a breaking change?
No, climatological_mean is retained and calls climatological_op.
Tests for climatological_mean were adjusted for minor changes in attribute values.
Other information:
Uses a wrapper for scipy.stats.linregress for trend calculation with xarray.