Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More intuitive exclusions #280

Merged
merged 3 commits into from
Oct 31, 2023
Merged

More intuitive exclusions #280

merged 3 commits into from
Oct 31, 2023

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented Oct 31, 2023 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • HISTORY.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • search_data_catalogs now loops through the provided keys, so that it actually eliminates anything that matches.

Does this PR introduce a breaking change?

  • No. The behaviour of exclusions will change, but this is a bugfix more than anything.

Other information:

@RondeauG RondeauG added the bug Something isn't working label Oct 31, 2023
aulemahal
aulemahal approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approuvé

@RondeauG RondeauG merged commit ee4dd33 into main Oct 31, 2023
6 checks passed
@RondeauG RondeauG deleted the fix-275 branch October 31, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

@sarahclaude sarahclaude Awaiting requested review from sarahclaude

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

search_data_catalogs exclusions with more than one key
2 participants
@RondeauG @aulemahal