-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better save_to_zarr #266
Merged
Better save_to_zarr #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RondeauG
reviewed
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I'll let @coxipi approve this, since this is his work.
coxipi
reviewed
Oct 16, 2023
coxipi
reviewed
Oct 16, 2023
coxipi
reviewed
Oct 16, 2023
coxipi
reviewed
Oct 16, 2023
Co-authored-by: Éric Dupuis <[email protected]>
coxipi
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
xs.io.round_bits
to round a floating point variable up to a number of bits, allowing for a much better compression afterwards.save_to_zarr
andsave_to_netcdf
, allowing to combine the bit rounding and the saving. The argument can take many forms for more flexibility.Does this PR introduce a breaking change?
No.
Other information:
Default keepbits value is guessed from the variable name, with a default of 12 (0.0122% of rel error). Better guesses should be given in
xs.io.KEEPBITS
, but I have none for now.