-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better resample #265
Merged
Merged
Better resample #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RondeauG
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
mccrayc
reviewed
Oct 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
Extends
resample
to explicitly cover the case where theinitial_frequency
is coarser than "W", meaning that it has a non-uniform length.DataArray.resample
for which a weighted version makes sense.resample(...).map(....weighted().op())
, with a special case for "median" since that's not aweighted
op. Mapping a function is less performant, especially since flox can't be used.method='mean'
that simplifies to a simpleresample().sum()
, meaning it should be much more performant and able to useflox
. Without dask and on the air dataset, I had a 3x speedup.Extends
resample
to handle missing values with newmissing
arg:mask
: Mask incomplete periods (as in missing timesteps)drop
: Drop incomplete periods (same)method=<xclim missing method>
: Mask periods failing specified xclim missing check.Does this PR introduce a breaking change?
No.
Other information: