Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the notebooks again #257

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Fix the notebooks again #257

merged 1 commit into from
Sep 15, 2023

Conversation

Zeitsperre
Copy link
Contributor

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • HISTORY.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Fixes the issue caused by running the notebooks twice by skipping the nbsphinx execution if _data is found
  • Stages an alternative approach to fixing the bug, which involves deleting _data between stages and running the notebooks twice, for reference

Does this PR introduce a breaking change?

No.

Other information:

@Zeitsperre Zeitsperre added the bug Something isn't working label Sep 15, 2023
@Zeitsperre Zeitsperre requested a review from RondeauG September 15, 2023 18:59
@Zeitsperre Zeitsperre self-assigned this Sep 15, 2023
@github-actions github-actions bot added CI Modifications to autiomation utilities docs labels Sep 15, 2023
RondeauG
RondeauG approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@RondeauG RondeauG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@Zeitsperre Zeitsperre merged commit 8ad78dd into main Sep 15, 2023
@Zeitsperre Zeitsperre deleted the fix-the-docs-again branch September 15, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RondeauG RondeauG RondeauG approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
bug Something isn't working CI Modifications to autiomation utilities docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeitsperre @RondeauG