-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging fixes #248
Packaging fixes #248
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@aulemahal @juliettelavoie No need to review everything, but I'd like you to look into the Notebooks, at least. I had to change them somewhat because we reduced the size of the underlying datasets.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'll wait for the others to look at it too (for my changes, at least).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
tests
are not treated as an installable package.tests_require
in thesetup.py
.requires_docs
torequires_netcdf
./docs/notebooks/samples
(from 16Mb to 400kb) and changed the Notebooks and tests to work around it.datablock_3d
moved to a newxscen.testing
xscen.testing.fake_data
to easily populate DataArrays with fake, but realistic data.Does this PR introduce a breaking change?
Sort of.
tests
no longer acts like an installable module. This wil only affect xscen developers who write tests.Other information:
This will be fully obsolete when we move to pyproject.toml, but, for those curious, why not use
tests_require
?