Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: RondeauG <[email protected]>
  • Loading branch information
juliettelavoie and RondeauG authored Oct 2, 2023
1 parent 8f4bfa8 commit 2a2b969
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions docs/notebooks/1_catalog.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@
"id": "5d8b7995",
"metadata": {},
"source": [
"Notice that the search fontion returns everything available that matchs some of the criteria."
"Notice that the search function returns everything available that matches some of the criteria."
]
},
{
Expand Down Expand Up @@ -248,7 +248,7 @@
"metadata": {},
"outputs": [],
"source": [
"# Only returns variable that have all members, source and experiment asked for. In this case, pr, but not sftlf.\n",
"# Only returns variables that have all members, source and experiment asked for. In this case, pr, but not sftlf.\n",
"DC.search(\n",
" source=\"NorESM2-MM\",\n",
" experiment=\"historical\",\n",
Expand Down
2 changes: 1 addition & 1 deletion xscen/extract.py
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@ def search_data_catalogs(
Variables and freqs to search for, following a 'variable: xr-freq-compatible-str' format. A list of strings can also be provided.
other_search_criteria : dict, optional
Other criteria to search for in the catalogs' columns, following a 'column_name: list(subset)' format.
You can also pass 'require_all_on: list(columns_name)' in order to only return results that respond to all other criteria across the listed columns.
You can also pass 'require_all_on: list(columns_name)' in order to only return results that correspond to all other criteria across the listed columns.
More details available at https://intake-esm.readthedocs.io/en/stable/how-to/enforce-search-query-criteria-via-require-all-on.html .
exclusions : dict, optional
Same as other_search_criteria, but for eliminating results.
Expand Down

0 comments on commit 2a2b969

Please sign in to comment.