-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heat spells #1885
Merged
Merged
Heat spells #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coxipi
reviewed
Aug 19, 2024
coxipi
reviewed
Aug 19, 2024
coxipi
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
tlogan2000
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
heat_spell_frequency
,heat_spell_max_length
andheat_spell_total_length
. The "heat_wave" indicators test that a bivariate condition on each day and then find consecutive runs of a minimum length. The new functions adhere to xclim's concept of "spell" : the condition is tested against a rolling N-day window and if it is fulfilled all days of the window are considered part of the spell.spell_mask
that encapsulate the spell notion. It returns a boolean mask of the days part of spells. The code has been added two features:var_reducer
('all' or 'any').Indicator
have changed accordingly (sorry).Does this PR introduce a breaking change?
No.
Other information:
I kinda decided that "heat" meant "tasmax and tasmin".