Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency pins, fix typo #1870

Merged
merged 20 commits into from
Aug 7, 2024
Merged

Update dependency pins, fix typo #1870

merged 20 commits into from
Aug 7, 2024

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Aug 6, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Synchronizes dependencies between pyproject.toml and environment.yml
  • Sets a few pins to their latest versions
  • Fixes a small typo in cli.py
  • Fixes an issue with the latest version of dask (2024.8.0)

Does this PR introduce a breaking change?

No.

Other information:

We currently have poppler (for PDF generation) listed as a dependency in the environment.yml. I'm going to see if things break when removing it.

@Zeitsperre Zeitsperre requested review from aulemahal and coxipi August 6, 2024 16:48
@Zeitsperre Zeitsperre marked this pull request as ready for review August 6, 2024 16:48
@github-actions github-actions bot added the API Interfacing and User Concerns label Aug 6, 2024
@github-actions github-actions bot added the CI Automation and Contiunous Integration label Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

Note

It appears that this Pull Request modifies the main.yml workflow.

On inspection, the XCLIM_TESTDATA_BRANCH environment variable is set to the most recent tag (v2023.12.14).

No further action is required.

@Ouranosinc Ouranosinc deleted a comment from coveralls Aug 6, 2024
@Zeitsperre Zeitsperre added the approved Approved for additional tests label Aug 6, 2024
tests/test_atmos.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the sdba Issues concerning the sdba submodule. label Aug 7, 2024
@Zeitsperre Zeitsperre mentioned this pull request Aug 7, 2024
5 tasks
@Zeitsperre
Copy link
Collaborator Author

@aulemahal Just needs your approval and we are good to merge!

@Zeitsperre Zeitsperre requested a review from aulemahal August 7, 2024 18:23
@Zeitsperre Zeitsperre merged commit a2b34f5 into main Aug 7, 2024
38 checks passed
@Zeitsperre Zeitsperre deleted the fixes branch August 7, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Interfacing and User Concerns approved Approved for additional tests CI Automation and Contiunous Integration sdba Issues concerning the sdba submodule.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants