-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cast high to float in jitter #1864
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
The docstring is a bit ambiguous as it says "a quantity with units". In the real xclim, this would mean that DataArrays are accepted. But we didn't use the @RondeauG, to your knowledge, would there ever be a use for have the jitter limits change along a given dimension ? (Like a specific jitter for each latitudes). My guess is no, so I suggest replacing the |
Many of the changes I made in that PR were to pin down what exactly the expectations were for each function. Like @aulemahal says, some function docstrings were very ambiguous. The |
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
high
to be a float, not an array. In the new version of dask, ifhigh
is an array, there are memory problems and we are unable to run jitter_under on the ESPO regions.mypy
compliance #1721. @Zeitsperre do you remember why ?Does this PR introduce a breaking change?
no
Other information:
This is only a problem when using dask.