Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix {hot|cold}_spell_max_length #1777

Merged
merged 4 commits into from
Jun 11, 2024
Merged

fix {hot|cold}_spell_max_length #1777

merged 4 commits into from
Jun 11, 2024

Conversation

coxipi
Copy link
Contributor

@coxipi coxipi commented Jun 11, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Fixes a bug. {hot|cold}_spell_max_length were not properly using window to only count spells with at least window time steps, now they do.

Does this PR introduce a breaking change?

  • Yes, output of functions will sometimes change (and work as expected)

Other information:

@github-actions github-actions bot added the indicators Climate indices and indicators label Jun 11, 2024
Zeitsperre
Zeitsperre approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGES.rst Outdated Show resolved Hide resolved
@github-actions github-actions bot added the approved Approved for additional tests label Jun 11, 2024
@coxipi @Zeitsperre
spelling sugg.
e3f04cd 
Co-authored-by: Trevor James Smith <[email protected]>
@Zeitsperre Zeitsperre merged commit c9847db into main Jun 11, 2024
19 checks passed
@Zeitsperre Zeitsperre deleted the fix_xyz_spell_total_length branch June 11, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees

@coxipi coxipi

Labels
approved Approved for additional tests indicators Climate indices and indicators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hardcoded window=1 in hot_spell_total_length and cold_spell_total_length
2 participants
@coxipi @Zeitsperre