Fix hawkins sutton smoke tests, linting #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeitsperre
commented
Jun 7, 2024
xclim/ensembles/_filters.py
Outdated
| @@ -51,6 +51,7 @@ def _concat_hist(da, **hist): | |||
|
|
|||
| # Select historical scenario and drop it from the data | |||
| h = da.sel(**hist).dropna("time", how="all") | |||
| h = h.drop_vars(dim) | |||
There was a problem hiding this comment.
Relevant changes here.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Zeitsperre
changed the title
|
I've set the test to be ignored for this specific xarray version. The upstream dev version seems to be working fine, so I don't want to risk changing outputs for a bug in the current xarray. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
codespell. Now ignoringSVGfiles.test_hawkins_sutton_smoketest due to strange behaviour withxarray.Does this PR introduce a breaking change?
No, AFAIK.