Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalized taylordiagram #1764

Merged
merged 12 commits into from
Jun 11, 2024
Merged

Normalized taylordiagram #1764

merged 12 commits into from
Jun 11, 2024

Conversation

coxipi
Copy link
Contributor

@coxipi coxipi commented May 29, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Add a bool option normalize and divide ref_std, sim_std by ref_std if True

Does this PR introduce a breaking change?

No

Other information:

I was planning a new plot option in figanos, but I was told we don't want to do any computation in figanos, it would be handy that sdba can manage this by itself.

@github-actions github-actions bot added the sdba Issues concerning the sdba submodule. label May 29, 2024
xclim/sdba/measures.py Outdated Show resolved Hide resolved
xclim/sdba/measures.py Outdated Show resolved Hide resolved
@Zeitsperre Zeitsperre requested a review from VascoSch92 June 10, 2024 21:57
xclim/sdba/measures.py Show resolved Hide resolved
xclim/sdba/measures.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the approved Approved for additional tests label Jun 10, 2024
@Zeitsperre Zeitsperre added this to the v0.50.0 milestone Jun 11, 2024
@Zeitsperre
Copy link
Collaborator

@coxipi Will merge this once the checks finish. All that's left is #1580 before the release!

@Zeitsperre Zeitsperre merged commit d291681 into main Jun 11, 2024
19 checks passed
@Zeitsperre Zeitsperre deleted the normalized_taylordiagram branch June 11, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests sdba Issues concerning the sdba submodule.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants