Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconfigure Builds and perform more doctests #1709

Merged
merged 9 commits into from
Apr 17, 2024
Merged

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Apr 16, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Splits the notebooks recipe in the tox.ini file
  • Sets the GitHub Workflows to test the doctests across more builds
  • Stages the tox-gh plugin for eventual integration

Does this PR introduce a breaking change?

Yes, tox-gh is now a development dependency and the "notebooks_doctests" tox recipe has been replaced with "notebooks", while doctest has been made into a modifier for typical tox runs to also run the documentation examples.

Other information:

https://github.com/tox-dev/tox-gh

@github-actions github-actions bot added the CI Automation and Contiunous Integration label Apr 16, 2024
Copy link

Note
It appears that this Pull Request modifies the main.yml workflow.

On inspection, the XCLIM_TESTDATA_BRANCH environment variable is set to the most recent tag (v2023.12.14).

No further action is required.

@Zeitsperre Zeitsperre added the approved Approved for additional tests label Apr 16, 2024
@coveralls
Copy link

coveralls commented Apr 17, 2024

Coverage Status

coverage: 90.638% (+0.4%) from 90.19%
when pulling 41fb7a8 on split-notebooks
into 2d8726b on main.

@Zeitsperre Zeitsperre marked this pull request as ready for review April 17, 2024 17:54
@Zeitsperre Zeitsperre requested a review from aulemahal April 17, 2024 17:54
@Zeitsperre Zeitsperre self-assigned this Apr 17, 2024
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

CHANGES.rst Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
@Zeitsperre Zeitsperre merged commit d27b4ed into main Apr 17, 2024
21 checks passed
@Zeitsperre Zeitsperre deleted the split-notebooks branch April 17, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests CI Automation and Contiunous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants