Snow season and days above #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zeitsperre
approved these changes
Apr 17, 2024
| ) | ||
|
|
||
| snw_days_above = SnowWithIndexing( | ||
| title="Days with snow (amount)", |
There was a problem hiding this comment.
"Days with snow greater than amount"?
Co-authored-by: Éric Dupuis <[email protected]>
EmilieBresson
approved these changes
Apr 18, 2024
|
@Zeitsperre it seems the doctests do not see the testing data ? Do you know what is happening ? |
|
@aulemahal I think the doctests are flakier than we imagined. It looks like there are data races / unsafe asynchronous read events that are causing problems. Re-running the failed tests might help for here, but we should address this ASAP. Will open an issue. |
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
sn[dw]_season_lengthtosn[dw]_days_above, which better reflects what they actually do.sn[dw]_season_lengthas an actual season length : duraction between a start and an end, both defined as the first day of a period of minimum length continuously above/under a given threshold.snw, like we said we'd do in 0.47 (youpsi).Does this PR introduce a breaking change?
Yes. An indicator name now points to another computation.
Other information: