Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing formatting words and operations for generic stats #1672

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

aulemahal
Copy link
Collaborator

@aulemahal aulemahal commented Feb 27, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes an issue raised by chat by @RondeauG
  • Tests for the changes have been added (for bug fixes / features
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Adds "integral", "count", "doymin" and "doymax" to the formattable words known by xclim. This would allow customizing long names and description. This mostly touches generic.stats for the moment.
    • I couldn't find how to word "count" and "doym??" as adjective...
  • I realized doymin was not accessible to generic.stats, so I added a mechanism to do it.

Does this PR introduce a breaking change?

No. It kinda only removes a warning for now : When op='integral' in generic.stats, the previous code raised a warning and then puts "integral"... which is what my added mapping does too.

Other information:

@aulemahal aulemahal requested a review from RondeauG February 27, 2024 20:41
@github-actions github-actions bot added the indicators Climate indices and indicators label Feb 27, 2024
@aulemahal aulemahal marked this pull request as ready for review February 27, 2024 20:43
xclim/data/fr.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the approved Approved for additional tests label Feb 27, 2024
@aulemahal aulemahal merged commit 408fad8 into main Feb 27, 2024
19 checks passed
@aulemahal aulemahal deleted the formatting-words branch February 27, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests indicators Climate indices and indicators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants