Remove eofs
#1621
Merged
Remove eofs
#1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… raise error when accessing first_eof
Zeitsperre
added
standards / conventions
github-actions
bot
added
sdba
On inspection, the No further action is required. |
aulemahal
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
What does @juliettelavoie think of this.
Were you using that property anywhere ? If yes, we'll need to reimplement it in a private script somewhere.
|
I don't have active scripts that use that property. I am okay to delete it without reimplementing it until we have a clear need for it. |
huard
approved these changes
Jan 25, 2024
Co-authored-by: David Huard <[email protected]>
5 tasks
Zeitsperre
added a commit
that referenced
this pull request
Jan 29, 2024
### What kind of change does this PR introduce? * Drops Python3.8 references and marks Python3.9 as base requirement. * Drops older `xarray` and `pandas` support. * Updates documentation and CI for dropped Python3.8. * Raises required versions of `scipy` and `numpy` (`1.9.0` and `1.20.0`, respectively). * Removes the `winter_storm` indice and indicator (deprecated in `xclim` v0.46.0). * Adopts the new syntax for frequency codes: - "A" is no more - Y -> YE, Q -> QE, M -> ME - H -> h, T -> min, S -> s, L -> ms, U -> us, N -> ns * Addresses several `DeprecationWarning` and `RuntimeWarning` messages related to `numpy`, `xarray`, and `pint` ### Does this PR introduce a breaking change? **Yes**, Python3.8 is no longer supported and base dependency versions have been augmented: - `numpy>=1.20.0` - `pandas>=2.2.0` - `scipy>=1.9.0` - `xarray>=2023.11.0` ### Other information: ~Python3.12 support is still not possible due to missing Python3.12 builds for `numba`. (This is being addressed in #1613)~ - This has been addressed. A Pull Request has been opened to address `DeprecationWarning`s stemming from `numpy` calls in `eofs` (ajdawson/eofs#148; `eofs` has been removed due to licensing-related issues (#1621))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
lmoments3andeofsis not permitted under GPLv3 #1620number) and pull request (:pull:number) has been addedWhat kind of change does this PR introduce?
eofslibrary has been removed from the optional dependencies.xclim.sdba.properties.first_eofand associated test) has been removed from the code base.eofsfunctionality.Does this PR introduce a breaking change?
Yes.
eofshas been completely removed since this violated its GPLv3 license. Associated functionality is reproducible by usersOther information:
Should we be offering users a note about how to migrate? I feel like it's not necessary.