Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix freq='D' behaviour of standardized indices #1607

Merged
merged 5 commits into from
Jan 22, 2024
Merged

fix freq='D' behaviour of standardized indices #1607

merged 5 commits into from
Jan 22, 2024

Conversation

coxipi
Copy link
Contributor

@coxipi coxipi commented Jan 19, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

*Fixes an error when using freq='D (or daily datasets with freq=None)

Does this PR introduce a breaking change?

No

Other information:

@github-actions github-actions bot added the indicators Climate indices and indicators label Jan 19, 2024
coxipi
coxipi commented Jan 19, 2024
View reviewed changes
tests/test_indices.py Outdated Show resolved Hide resolved
aulemahal
aulemahal approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@github-actions github-actions bot added the approved Approved for additional tests label Jan 22, 2024
@coveralls
Copy link

Coverage Status

coverage: 90.299% (+0.02%) from 90.278%
when pulling f68a0fe on spi_day_bug
into ccf574c on master.

@coxipi coxipi merged commit 8aea213 into master Jan 22, 2024
19 checks passed
@coxipi coxipi deleted the spi_day_bug branch January 22, 2024 22:10
@aulemahal aulemahal mentioned this pull request Jan 24, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre left review comments

@aulemahal aulemahal aulemahal approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests indicators Climate indices and indicators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coxipi @coveralls @Zeitsperre @aulemahal