Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic Version v2.0.0 Specification #1569

Merged
merged 9 commits into from
Dec 29, 2023
Merged

Semantic Version v2.0.0 Specification #1569

merged 9 commits into from
Dec 29, 2023

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Dec 22, 2023

Pull Request Checklist:

What kind of change does this PR introduce?

  • xclim now adheres to the Semantic Versioning 2.0.0 specification.
  • bump2version has been replaced with bump-my-version
  • The setup.cfg has been deleted; flake8 configurations have migrated to .flake8 file, and bumpversion configuration is now found in pyproject.toml.
  • Fixed an issue with the .gitignore to properly ignore some autogenerated files.

Does this PR introduce a breaking change?

Yes. The versioning system has been adjusted so that patch versions are not augmented at every push to xclim code; instead, the build version is adjusted.

Other information:

https://callowayproject.github.io/bump-my-version/

@Zeitsperre Zeitsperre requested a review from huard December 22, 2023 20:56
@github-actions github-actions bot added the CI Automation and Contiunous Integration label Dec 22, 2023
@Zeitsperre Zeitsperre requested review from bzah and aulemahal December 22, 2023 20:56
@Zeitsperre Zeitsperre self-assigned this Dec 22, 2023
@Zeitsperre Zeitsperre added the standards / conventions Suggestions on ways forward label Dec 22, 2023
@Zeitsperre Zeitsperre added this to the v0.48.0 milestone Dec 22, 2023
@github-actions github-actions bot added information For development/intsructional purposes docs Improvements to documenation labels Dec 24, 2023
Copy link

Note
It appears that this Pull Request modifies the main.yml workflow.

On inspection, the XCLIM_TESTDATA_BRANCH environment variable is set to the most recent tag (v2023.12.14).

No further action is required.

Copy link
Contributor

@bzah bzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
In the github action, I think you could have get the current_version and new_version using bump-my-version show argument (see here for example), but the regex works fine too.

Joyeuses fêtes !

@github-actions github-actions bot added the approved Approved for additional tests label Dec 26, 2023
@Zeitsperre Zeitsperre merged commit d6dd420 into master Dec 29, 2023
24 checks passed
@Zeitsperre Zeitsperre deleted the semver-v2 branch December 29, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests CI Automation and Contiunous Integration docs Improvements to documenation information For development/intsructional purposes standards / conventions Suggestions on ways forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop bump2version for bump-my-version Deployment policy and SemVer v2-compliant versioning
2 participants