Validate YAML file using schema before constructing module.

[huard]

Pull Request Checklist:

• This PR addresses an already opened issue (for bug fixes / features)
  • This PR fixes Validate YAML using schema #1523
• Tests for the changes have been added (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features)
• CHANGES.rst has been updated (with summary of main changes)
  • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

• Use Yamale to validate schema before constructing module. Good news, no error found in the test suite.

Does this PR introduce a breaking change?

Other information:

There was an issue raised by @tlogan2000 about indicators accepting wrong arguments without failing. Could you post an offending example ?

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[aulemahal]

Looks great!

I first thought that the other issue raised by @tlogan2000 was for yamls like this:

realm: atmos
indicators:
  tg:
    base: tg_mean
    parameters:
      frq: MS

where "frq" is misspelt. However, I just tested and this raises an error. So either the original error was fixed elsewhere, or the error was with the keys a level above, and this PR fixes it.

[huard]

Did you test it with or without this PR ?

[aulemahal]

With and without.

realm: atmos
indicators:
  tg:
    base: tg_mean
    parameters:
      frq: MS

fails on both, while

realm: atmos
indicators:
  tg:
    base: tg_mean
    parametrs:
      freq: MS

fails only here.

[huard]

Ok, let's merge this then and see if anything else comes up.

[huard]

Should we worry about the error in test_encoding ? This occurs in icclim.yml

UnicodeDecodeError: 'gbk' codec can't decode byte 0xa5 in position 4213: illegal multibyte sequence

[huard]

C'est "≥" qui cause problème.