Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix window attrs in SPI/SPEI #1554

Merged
merged 10 commits into from
Jan 9, 2024
Merged

Fix window attrs in SPI/SPEI #1554

merged 10 commits into from
Jan 9, 2024

Conversation

coxipi
Copy link
Contributor

@coxipi coxipi commented Dec 11, 2023 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • If params is not given, we pre-process dataset (resampling with freq rolling with a general window) before doing anything, then compute params with freq=None, window=1. But we must adjust attrs to reflect the rolling window done before computing the params.
  • I added a missing reference for the approximation of gamma parameters

Does this PR introduce a breaking change?

No

Other information:

Yet another spi fix attrs ... oups

@github-actions github-actions bot added the indicators Climate indices and indicators label Dec 11, 2023
@coveralls
Copy link

coveralls commented Dec 11, 2023 •
edited
Loading

Coverage Status

coverage: 90.304% (+0.001%) from 90.303%
when pulling 02f7457 on fix_spi_attrs_2
into 7d79184 on master.

@github-actions github-actions bot added the approved Approved for additional tests label Dec 11, 2023
aulemahal
aulemahal requested changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

CHANGES.rst Outdated Show resolved Hide resolved
@github-actions github-actions bot added the docs Improvements to documenation label Dec 23, 2023
@coxipi coxipi merged commit dd9db13 into master Jan 9, 2024
15 of 16 checks passed
@coxipi coxipi deleted the fix_spi_attrs_2 branch January 9, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests docs Improvements to documenation indicators Climate indices and indicators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coxipi @coveralls @aulemahal @Zeitsperre