Fix data flags var name generation #1507
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
Changes how the data flags variable names are generated.
In the previous version, every kwargs was sent to
str2pint
. We were relying on atry: except
to catch those kwargs that weren't quantities. This had the caveat of requiring an explicit list of possible errors. @RondeauG had a case whereop='>='
was triggering aValueError
, which wasn't listed.I changed this "implicit" parsing to an "explicit" one:
This required:
Does this PR introduce a breaking change?
Yes, I made the arbitrary choice of changing how we stringify the minus sign:
However, I don't think this will affect many projects.
Other information:
@RondeauG , could you try this new branch with your code ? (That's why I made you a reviewer)