Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snow storm days indices (and change snw_season_XYZ default thresholds) #1505

Merged
merged 21 commits into from
Oct 18, 2023
Merged

Snow storm days indices (and change snw_season_XYZ default thresholds) #1505

merged 21 commits into from
Oct 18, 2023

Conversation

coxipi
Copy link
Contributor

@coxipi coxipi commented Oct 17, 2023 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • New indicators ( snd_storm_days [renaming], snw_storm_days) and change default thresholds in snw_season indicators.
  • Deprecation wrappers are added
  • Various old lingering deprecation warnings from other PRs are removed

Does this PR introduce a breaking change?

Yes.

  • Rename : winter_storm -> snd_storm_days
  • Change default thresholds in snw_season_XYZ indices

Other information:

@github-actions github-actions bot added the indicators Climate indices and indicators label Oct 17, 2023
Zeitsperre
Zeitsperre reviewed Oct 17, 2023
View reviewed changes
CHANGES.rst Outdated Show resolved Hide resolved
CHANGES.rst Outdated Show resolved Hide resolved
xclim/data/fr.json Outdated Show resolved Hide resolved
xclim/indicators/land/_snow.py Outdated Show resolved Hide resolved
xclim/indices/_threshold.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the approved Approved for additional tests label Oct 18, 2023
@coxipi coxipi merged commit 8c40c91 into master Oct 18, 2023
12 checks passed
@coxipi coxipi deleted the snow_storm_days branch October 18, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests indicators Climate indices and indicators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coxipi @Zeitsperre