Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keywords, move indicators API to its own page #1502

Merged
merged 7 commits into from
Oct 16, 2023
Merged

Conversation

aulemahal
Copy link
Collaborator

@aulemahal aulemahal commented Oct 13, 2023

Pull Request Checklist:

What kind of change does this PR introduce?

  • Changes how the "keyword" attribute is inherited between indicators to inherit by concatenating.
  • Add basic keywords to all subclasses
  • Move the indicators API to its own page to lower loading times (it's still slow, but a lot more bearable IMO)

Does this PR introduce a breaking change?

No.

Other information:

@aulemahal aulemahal requested a review from Zeitsperre October 13, 2023 18:33
@github-actions github-actions bot added docs Improvements to documenation indicators Climate indices and indicators labels Oct 13, 2023
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a bunch of sense and is indeed quicker to load!

@github-actions github-actions bot added the approved Approved for additional tests label Oct 16, 2023
@Zeitsperre
Copy link
Collaborator

This PR just needs its Changes.rst updated and we can merge!

@Zeitsperre Zeitsperre merged commit 21388ff into master Oct 16, 2023
12 checks passed
@Zeitsperre Zeitsperre deleted the add-keywords branch October 16, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests docs Improvements to documenation indicators Climate indices and indicators
Projects
2 participants