Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importlib.resources deprecations for py 3.9 #1485

Merged
merged 9 commits into from
Oct 16, 2023

Conversation

aulemahal
Copy link
Collaborator

@aulemahal aulemahal commented Sep 27, 2023

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

Fix for the deprecation warnings that importlib.resources throws. It changes how we open and parse our module data files.

Does this PR introduce a breaking change?

Yes, the deprecation concerns python 3.9 and above, so this needs to be merged only when we pin python above 3.8.

Other information:

I made this PR so I don't lose the changes I had already made, but there's no rush at all.

@github-actions github-actions bot added the approved Approved for additional tests label Oct 2, 2023
@github-actions github-actions bot added the CI Automation and Contiunous Integration label Oct 16, 2023
@github-actions
Copy link

Note
It appears that this Pull Request modifies the main.yml workflow.

On inspection, the XCLIM_TESTDATA_BRANCH environment variable is set to the most recent tag (v2023.9.12).

No further action is required.

@Zeitsperre
Copy link
Collaborator

@aulemahal Want me to finalize this here? We can get this into v0.46.0 for sure

@aulemahal
Copy link
Collaborator Author

Ah! Now that you added retrocompatibility, why not!

@aulemahal aulemahal marked this pull request as ready for review October 16, 2023 17:29
@Zeitsperre Zeitsperre merged commit 2c50941 into master Oct 16, 2023
13 checks passed
@Zeitsperre Zeitsperre deleted the fix-importlib-deprecation branch October 16, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests CI Automation and Contiunous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants