Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise when reduced dims are chunked in map_blocks #1482

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Conversation

aulemahal
Copy link
Collaborator

Pull Request Checklist:

What kind of change does this PR introduce?

If a map_blocks-wrapped function receives input chunked along the dimensions marked as "reduced", it raises an error.

This means one cannot chunk the training dataset (QM.ds, for example) along the distribution ('quantiles') or group ('month', 'dayofyear') dimensions.

Previously, this didn't raise an error, but the adjustment would be done separately for each chunk, yielding incorrect results, silently.

Does this PR introduce a breaking change?

No.

Other information:

@github-actions
Copy link

Warning
This Pull Request is coming from a fork and must be manually tagged approved in order to perform additional testing.

@github-actions github-actions bot added the sdba Issues concerning the sdba submodule. label Sep 27, 2023
@aulemahal
Copy link
Collaborator Author

@github-actions, this ain't a fork, this is the OG xclim! Bad bot.

@Zeitsperre
Copy link
Collaborator

@aulemahal

I wish the bot was at fault here, haha. Will push a fix soon.

@github-actions github-actions bot added the approved Approved for additional tests label Sep 27, 2023
@coveralls
Copy link

Coverage Status

coverage: 90.492% (+0.02%) from 90.468% when pulling c846ca6 on fix-1481 into 0a48bbc on master.

@aulemahal aulemahal merged commit e9596e5 into master Sep 28, 2023
23 checks passed
@aulemahal aulemahal deleted the fix-1481 branch September 28, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests sdba Issues concerning the sdba submodule.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Odd behaviour when chunks are used along quantiles and time grouper dimensions in SDBA EQM.
4 participants