Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pull_request_target workarounds, and labeling fixes #1479

Merged
merged 5 commits into from
Sep 21, 2023
Merged

pull_request_target workarounds, and labeling fixes #1479

merged 5 commits into from
Sep 21, 2023

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Sep 18, 2023 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Deals with a security-related bug/feature that prevents Pull Requests coming from forks from being tagged automatically.
  • Prevents changes to the .zenodo.json file being labelled as CI-related.

Does this PR introduce a breaking change?

No.

Other information:

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target

@Zeitsperre Zeitsperre self-assigned this Sep 18, 2023
@github-actions github-actions bot added the CI Automation and Contiunous Integration label Sep 18, 2023
@Zeitsperre Zeitsperre marked this pull request as ready for review September 21, 2023 15:39
aulemahal
aulemahal approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@github-actions github-actions bot added the approved Approved for additional tests label Sep 21, 2023
@Zeitsperre Zeitsperre merged commit 0a48bbc into master Sep 21, 2023
19 checks passed
@Zeitsperre Zeitsperre deleted the labeling_fixes branch September 21, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aulemahal aulemahal aulemahal approved these changes

Assignees

@Zeitsperre Zeitsperre

Labels
approved Approved for additional tests CI Automation and Contiunous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeitsperre @aulemahal