triheatmap #265
triheatmap #265
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Ignore the |
|
I am thinking about this more and I am not sur if the list of |
src/figanos/matplotlib/plot.py
Outdated
|
|
||
| def triheatmap( | ||
| data: xr.DataArray | xr.Dataset, | ||
| dim: str, |
There was a problem hiding this comment.
Could use hue instead of dim to be similar to xarray plot: https://docs.xarray.dev/en/stable/user-guide/plotting.html
There was a problem hiding this comment.
well hue means color, I'm not sure it's adapted here has the triangles could be the same colors. how about tri_dim or triangle ?
| ---------- | ||
| data : DataArray or Dataset | ||
| Input data do plot. | ||
| ax : matplotlib axis, optional |
src/figanos/matplotlib/plot.py
Outdated
| f"The length of the dimensiondim ({dim},{len(d)}) should be either 2 or 4. It represents the number of triangles." | ||
| ) | ||
|
|
||
| plt.xlabel(other_dims[0]) |
There was a problem hiding this comment.
Could xlabel or ylabel also be linked to use_attrs?
Pull Request Checklist:
number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
no
Other information: