Resolve issues around building containers; missing dependencies. #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datdamnzotz
reviewed
Dec 26, 2021
project.clj
Outdated
| @@ -37,7 +37,7 @@ | |||
| [re-frame "0.10.9"] | |||
| [reagent "0.7.0"] | |||
| [garden "1.3.2"] | |||
| [org.apache.pdfbox/pdfbox "2.1.0-20170324.170253-831"] | |||
| [org.apache.pdfbox/pdfbox "2.0.25"] | |||
There was a problem hiding this comment.
You didn't test with this version - I have and it doesn't produce PDF's.
I have a pull request coming to fix PdfBox so you can remove it from this pull request.
There was a problem hiding this comment.
You're right; I overlooked your fix. Sorry 'bout that.
datdamnzotz
reviewed
Dec 26, 2021
|
Given that, as 'zots pointed out, we have other (better) ways to build the orcpub-datomic container, and a better solution to the PDFBox problem exists, maybe it's best to close the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes #549 and #539
Since Cognitect has ceased making datomic-free versions available, the current method of building the orcpub-datomic container is permanently broken. This is a workaround.
I've included a fix for the PDFBox (539) problem as well.
Checklist: