Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

Prevent multiple license requests #209

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

onotole
Copy link
Contributor

@onotole onotole commented Dec 20, 2017

No description provided.

@bbert
Copy link

bbert commented Dec 21, 2017

I don't understand the need for this PR.
The generateKeyRequest() should be called when creating MediaKeySession.

@onotole
Copy link
Contributor Author

onotole commented Dec 22, 2017

There are few issues here:

  1. According to https://dvcs.w3.org/hg/html-media/raw-file/eme-v0.1b/encrypted-media/encrypted-media.html, there is no such thing as KeySession (explicit drm session management was introduced in later specs).
  2. There is a race condition in initial license request generation approach - if we would do it ASAP then, according to algorithm https://dvcs.w3.org/hg/html-media/raw-file/eme-v0.1b/encrypted-media/encrypted-media.html#dom-generatekeyrequest, step 2, we will fail because video tag isn't ready yet (to be safe here we need to wait until needkey event). It is quite strange limitation but webkit follows this recommended algorithm precisely. And, as I can imagine, IE is more permissive here.

@bbert
Copy link

bbert commented Dec 22, 2017

The point is that I do not have any terminal/browser that implements this EME version in order to test.
On IE11, the ProtectionModel_3Feb2014 is used.
Does anyone is able to check also this PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants