Chore merge 13th of Feb #1829
Merged
Chore merge 13th of Feb #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
julien-deramond
force-pushed
the
main-jd-chore-merge-13-feb
branch
from
73fbac4 to
7d172e5
Compare
julien-deramond
force-pushed
the
main-jd-chore-merge-13-feb
branch
from
51b9b23 to
a559cde
Compare
8 tasks
louismaximepiton
requested changes
Feb 15, 2023
| // Underline | ||
| // | ||
|
|
||
| .nav-underline { |
There was a problem hiding this comment.
[Bootstrap Side] As discussed in private, should definetely be only a redefinition on CSS variables so enrich the basic nav and remove all but CSS variables in here and in all nav modes.
Co-authored-by: Louis-Maxime Piton <[email protected]>
I add it to the list in twbs/bootstrap#37309
Not mandatory IMO but we can inform them about this change |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following commit coming from Bootstrap has been isolated in this PR because of the complexity of the review: twbs/bootstrap@7d9aa9d.
The principle here is that "Tabs light" nav is replaced by the variant coming from Bootstrap: "Underline".
"Tabs light" were built based on
--bs-nav-tabs-*CSS vars. Since we don't use.nav-tabsin combination of.nav-underlinea big part of the content of.nav-tabsCSS vars and rules has been copied into.nav-underline. I'm not sure I can do better here, but if you have any ideas don't hesitate.This change also implies a breaking change for the Nested Tabs second row which now uses "Underline" nav.
I wanted to redirect the URLs with anchors between v5.2 and v5.3 but that's not going to be possible.
Live previews