Add Shock configuration, slight clean up of Config screen #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Legrems
reviewed
Sep 25, 2019
Modules/ModParser-3_0.lua
Outdated
| @@ -997,7 +995,7 @@ local specialModList = { | |||
| mod("BlockChance", "MORE", -30), | |||
| mod("SpellBlockChance", "MORE", -30) | |||
| }, | |||
| ["maximum life becomes 1, immune to chaos damage"] = { flag("ChaosInoculation") }, | |||
| ["maximum life becomes 1, immune to chaos damage"] = {flag("ChaosInoculation") }, | |||
There was a problem hiding this comment.
Oh, woops. I was messing around with trying to get the Full Life setting to show up when you have Chaos Inoculation, just to be absolutely sure it puts you down as on Full Life. For some reason I couldn't get it to work so I just undid all the stuff I changed, but I didn't even realize I erased that space. Not a needed change, obviously!
|
Commit message are not very self-explaining btw ;P |
made self-shock config apply increased damage taken
update shock tooltip
update shock tooltip AGAIN this is a nightmare
supports elusive and unifies wither with the withered debuff available elsewhere
left a comment in on accident
removed comment I didn't intend to leave in
|
I was looking for this option ever since skitterbots were released. This needs to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a way to choose how effective Shock is. The option only shows up and applies to the enemy when "Enemy is Shocked?" is ticked. The ticked box makes any Shocked modifiers apply to the enemy without applying any increased damage taken, so only the input box increases damage taken. I also changed the tooltip to explain Shock a tiny bit by mentioning what the normal base Shock is and that it scales with Shock/Ailment effectiveness.
When testing this, on some builds, ticking Shocked or disabling it would make the entire Config screen move because it was small enough to fit without the input box there, and too big to fit when the box is there.
To try to help a bit, I hid the config for always being on Full Life unless the toggle is relevant, since it's relatively rare.
I mostly just wanted the Shock changes in, maybe there's some reason that the option I hid is always there. But I personally think it's better with it hidden.