-
-
Notifications
You must be signed in to change notification settings - Fork 96
[devices] Add Intermatic PE653 MultiWave Receiver #618
Conversation
Why did you added the switchs too? Aren’t them automatically discovered? |
The switched ended up incorrectly labeled in confusing ways when auto
discovered. It's a bit better with my patch to the open zwave devices
(removes a redundant switch instance) but I figured I would leave them in
here for completeness.
…On Fri, Jul 3, 2020 at 3:00 PM Daniel Lando ***@***.***> wrote:
Why did you added the switchs too? Aren’t them automatically discovered?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#618 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAY7BGNJBN7MRSAZOSGJKLRZZIIXANCNFSM4OQC2MXQ>
.
|
Could you fix lint errors? Just run npm run lint-fix |
Sure, I'll take care of it.
…On Fri, Jul 3, 2020 at 11:45 PM Daniel Lando ***@***.***> wrote:
Could you fix lint errors? Just run npm run lint-fix
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#618 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAY7BDQIQJZJTFLSOCGKZLRZ3FXRANCNFSM4OQC2MXQ>
.
|
// Intermatic PE653 MultiWave Receiver | ||
{ | ||
type: 'climate', | ||
object_id: 'pool_thermostat', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use more generic names? Is this device usually used to create this entities or is just for your use case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the names used by the device itself, see next comment.
}, | ||
{ | ||
type: 'climate', | ||
object_id: 'spa_thermostat', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. Then seems this are configured in the same way so you will have 2 thermostats that controls same values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are actually two thermostat instances, 67-1-1 and 67-1-7 but curiously only one water temperature sensor 49-1-1 that is used for both. The thermostats have dedicated functions in the system. One thermostat is used specifically for Pool temperature and the other for Spa temperature and they are labeled as such in the UI.
There's also support for air temperature and freeze sensors as well as some other auxiliary equipment I don't have, so that can be added by someone else later. More information here if you're curious: https://www.intermatic.com/-/media/inriver/7092-8536.ashx
@j9brown News on this? |
I’ll get back to you this afternoon.
…On Thu, Jul 9, 2020 at 11:51 PM Daniel Lando ***@***.***> wrote:
@j9brown <https://github.com/j9brown> News on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#618 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAY7BG5JXVRDJH54D35ORDR22273ANCNFSM4OQC2MXQ>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This change depends on the following patch to OpenZWave: OpenZWave/open-zwave#2289