Skip to content

Commit

Permalink
cpu-o3: fix earlyscoreboard should not update by float and vector (#245)
Browse files Browse the repository at this point in the history
Change-Id: I264e4366cdb03f9ed1a34840879cad380bbae20d
  • Loading branch information
tastynoob authored Dec 27, 2024
1 parent dbf88fd commit 9463f90
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
6 changes: 3 additions & 3 deletions src/cpu/o3/FuncUnitConfig.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@
from m5.objects.FuncUnit import *

class IntMisc(FUDesc):
opList = [ OpDesc(opClass='No_OpClass') ]
opList = [ OpDesc(opClass='No_OpClass'),
OpDesc(opClass='VectorConfig') ]

class IntALU(FUDesc):
opList = [ OpDesc(opClass='IntAlu') ]
Expand Down Expand Up @@ -126,8 +127,7 @@ class SIMD_Unit(FUDesc):
OpDesc(opClass='VectorIntegerReduce'),
OpDesc(opClass='VectorFloatReduce'),
OpDesc(opClass='VectorMisc'),
OpDesc(opClass='VectorIntegerExtension'),
OpDesc(opClass='VectorConfig')]
OpDesc(opClass='VectorIntegerExtension')]

class PredALU(FUDesc):
opList = [ OpDesc(opClass='SimdPredAlu') ]
Expand Down
13 changes: 7 additions & 6 deletions src/cpu/o3/issue_queue.cc
Original file line number Diff line number Diff line change
Expand Up @@ -902,13 +902,14 @@ Scheduler::specWakeUpDependents(const DynInstPtr& inst, IssueQue* from_issue_que
from_issue_queue->getName(), to->getName(), wakeDelay);
if (wakeDelay == 0) {
to->wakeUpDependents(inst, true);
for (int i = 0; i < inst->numDestRegs(); i++) {
PhysRegIdPtr dst = inst->renamedDestIdx(i);
if (dst->isFixedMapping()) [[unlikely]] {
continue;
;
if (!(inst->isFloating() || inst->isVector())) {
for (int i = 0; i < inst->numDestRegs(); i++) {
PhysRegIdPtr dst = inst->renamedDestIdx(i);
if (dst->isFixedMapping()) [[unlikely]] {
continue;
}
earlyScoreboard[dst->flatIndex()] = true;
}
earlyScoreboard[dst->flatIndex()] = true;
}
} else {
auto wakeEvent = new SpecWakeupCompletion(inst, to);
Expand Down

0 comments on commit 9463f90

Please sign in to comment.