Decoupling KurentoSessionManager to support MediaMode.RELAYED #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Adjut KurentoSessionManager and SessionRestController
… based on the used MediaMode
… KurentoSessionManager
… and SessionManagerProvider
thojou
force-pushed
the
feature/decouple-kurento
branch
from
aeb63c1 to
798a7b7
Compare
|
We are studying this right now. Stay tuned! |
|
Next week we will discuss this PR. The idea behind it looks good. Maybe some little adjustments are needed, but this changes will be probably merged into the master branch. |
|
Sounds great! Let me know if you want me to change something. |
|
Any update on this? |
|
A mayor refactoring of OpenVidu internals will be carried in the next weeks. |
|
Is there any news or time estimate for this to be available? Thank you very much for such a powerful project |
|
Sorry but this is not in our short term roadmap |
CSantosM
force-pushed
the
master
branch
2 times, most recently
from
7fe1145 to
d3a755b
Compare
CSantosM
force-pushed
the
master
branch
10 times, most recently
from
e9de7f5 to
7d88c1f
Compare
CSantosM
force-pushed
the
master
branch
2 times, most recently
from
670697a to
6ab6c22
Compare
CSantosM
force-pushed
the
master
branch
3 times, most recently
from
bc3613c to
86d1260
Compare
CSantosM
force-pushed
the
master
branch
2 times, most recently
from
4df7846 to
5349177
Compare
CSantosM
force-pushed
the
master
branch
3 times, most recently
from
5847916 to
0cff58e
Compare
CSantosM
force-pushed
the
master
branch
10 times, most recently
from
bfa4d17 to
33d1192
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
While working on my Master thesis, i analysed Kurento Media Server and the OpenVidu implementation and got in contact with the
MediaMode.RelayedOption.I have read #37 and noticed, that this feature does not have a high priority.
For my project it is required to also support a direct connection between peers, so i started to implement this feature on my own.
After digging into the code i found out, that there are some general components like
RpcHandlerandSessionRestControllerwhich are currently tightly coupled with the KurentoSessionManager, because it is the only explicit implementation of a SessionManager.So first of all i tried to decouble the KurentoSessionManger, so that it will be possible to inject another Manager based on the MediaMode used in a session.
In my approach it was necessary to change some elementary code base and i would like to know if these changes would be conform with your internal roadmap.
I would love to see this changes getting into the core (maybe with some adjustments). Nevertheless i will continue implementing the
MediaMode.Relayedfor at least my own project.