ov-components: Fixed fullscreen e2e test

OpenVidu · Jul 29, 2024 · 1e47d69 · 1e47d69
1 parent d52dc9b
commit 1e47d69
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 9 deletions.
diff --git a/.github/workflows/openvidu-components-angular-E2E.yml b/.github/workflows/openvidu-components-angular-E2E.yml
@@ -58,8 +58,10 @@ jobs:
         uses: actions/setup-node@v4
         with:
           node-version: '20'
-      - name: Run Browserless Chrome
-        run: docker run -d -p 3000:3000 --network host browserless/chrome:1.57-chrome-stable
+      # - name: Run Browserless Chrome
+      #   run: docker run -d -p 3000:3000 --network host browserless/chrome:1.57-chrome-stable
+      - name: Run Chrome
+        run:  docker run --network=host -p 4444:4444 selenium/standalone-chrome:127.0
       - name: Run openvidu-local-deployment
         run: |
           git clone --depth 1 https://github.com/OpenVidu/openvidu-local-deployment
@@ -111,8 +113,10 @@ jobs:
         uses: actions/setup-node@v4
         with:
           node-version: '20'
-      - name: Run Browserless Chrome
-        run: docker run -d -p 3000:3000 --network host browserless/chrome:1.57-chrome-stable
+      # - name: Run Browserless Chrome
+      #   run: docker run -d -p 3000:3000 --network host browserless/chrome:1.57-chrome-stable
+      - name: Run Chrome
+        run:  docker run --network=host -p 4444:4444 selenium/standalone-chrome:127.0
       - name: Run openvidu-local-deployment
         run: |
           git clone --depth 1 https://github.com/OpenVidu/openvidu-local-deployment
@@ -164,8 +168,10 @@ jobs:
   #       uses: actions/setup-node@v4
   #       with:
   #         node-version: '20'
-  #     - name: Run Browserless Chrome
-  #       run: docker run -d -p 3000:3000 --network host browserless/chrome:1.57-chrome-stable
+      # - name: Run Browserless Chrome
+      #   run: docker run -d -p 3000:3000 --network host browserless/chrome:1.57-chrome-stable
+      # - name: Run Chrome
+      #   run:  docker run --network=host -p 4444:4444 selenium/standalone-chrome:127.0
   #     - name: Run openvidu-local-deployment
   #       run: |
   #         git clone --depth 1 https://github.com/OpenVidu/openvidu-local-deployment

diff --git a/openvidu-components-angular/e2e/nested-components/events.test.ts b/openvidu-components-angular/e2e/nested-components/events.test.ts
@@ -101,6 +101,8 @@ describe('Testing EVENTS', () => {
 
 		await utils.toggleFullscreenFromToolbar();
 
+		await browser.sleep(1000);
+
 		await utils.waitForElement('#onFullscreenEnabledChanged');
 		expect(await utils.isPresent('#onFullscreenEnabledChanged')).to.be.true;
 	});

diff --git a/openvidu-components-angular/e2e/selenium.conf.ts b/openvidu-components-angular/e2e/selenium.conf.ts
@@ -56,7 +56,7 @@ export const WebComponentConfig: BrowserConfig = {
 
 export const NestedConfig: BrowserConfig = {
 	appUrl: 'http://localhost:4200/#/testing',
-	seleniumAddress: LAUNCH_MODE === 'CI' ? 'http://localhost:3000/webdriver' : '',
+	seleniumAddress: LAUNCH_MODE === 'CI' ? 'http://localhost:4444/wd/hub' : '',
 	browserName: 'Chrome',
 	browserCapabilities: Capabilities.chrome().set('acceptInsecureCerts', true),
 	browserOptions: new chrome.Options().addArguments(...(LAUNCH_MODE === 'CI' ? chromeArgumentsCI : chromeArguments))

diff --git a/openvidu-components-angular/e2e/utils.po.test.ts b/openvidu-components-angular/e2e/utils.po.test.ts
@@ -123,9 +123,9 @@ export class OpenViduComponentsPO {
 		// Open more options menu
 		await this.toggleToolbarMoreOptions();
 
-		const fullscreenButton = await this.waitForElement('#fullscreen-btn');
+		await this.waitForElement('#fullscreen-btn');
 		expect(await this.isPresent('#fullscreen-btn')).to.be.true;
-		await fullscreenButton.click();
+		await this.clickOn('#fullscreen-btn');
 	}
 
 	async togglePanel(panelName: string) {