Always update tray icon on state change

The tray icon and its tip text get updated to the connecting state when starting a new status window thread. This is not enough for persistent connections as these can be restarted from the hold state which does not go through a new thread creation. To see the bug, disconnect and reconnect a persistent connection and have it wait in the connecting state. The tray icon colour does not change to yellow and the tray tip message does not show the "Connecting to:" text. Fix by ensuring that CheckAndSetTrayIcon() or SetTrayIcon() gets called whenever a state change message is received. Fixes issue #668 Signed-off-by: Selva Nair <[email protected]>
OpenVPN · Feb 9, 2024 · 33325b7 · 33325b7
1 parent 813916e
commit 33325b7
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/openvpn.c b/openvpn.c
@@ -438,6 +438,10 @@ OnStateChange(connection_t *c, char *data)
             SetStatusWinIcon(c->hwndStatus, ID_ICO_CONNECTING);
         }
     }
+    else
+    {
+        CheckAndSetTrayIcon();
+    }
 }
 
 static void