Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely sure what is happening here yet. There is a 2nd http/2 request to GH to pull the favicon.ico and it results in a 400 code which might be affecting request.
See also:
Btw this results in a server trip without this of:
Affects at least:
Working url: https://raw.githubusercontent.com/Martii/UserScripts/master/res/world.png
Non-working url: https://raw.githubusercontent.com/thoughtsunificator/anime-twist-premium-extension/master/public/resource/icon256.png
Header Response difference (non-working):
... Ref https://developer.mozilla.org/docs/Web/HTTP/Headers/TE
Assumption: I think that the
req.abort()
occasionally generatesECONNRESET
even though the@icon
was sufficiently chunked and processed with its callback. Poking around the node source the methodology in this PR appears to be what they are doing a lot of the time. i.e.// fallsthrough
. I now don't think it's a browser issue... still could be a dep issue but more likely it's a "feature" that was cleaned up in later node upgrades.