Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force DOIs to URL form for taxonomic amendments. #192

Closed
wants to merge 1 commit into from

Conversation

jimallman
Copy link
Member

This will convert existing amendments on-the-fly (when fetched) and enforce DOIs-as-URLs when adding or changing a taxonomic amendment.

N.B. This is dependent on the coerce_amendment_dois_to_urls branch of peyotl!

N.B. This is dependendent on the `coerce_amendment_dois_to_urls` branch
of peyotl!
@jimallman
Copy link
Member Author

This is working now on devtree. Tested with multiple taxa in a single new amendment, and fetching old/existing amendments via API (response is converted to use DOIs-as-URLs).

@jimallman
Copy link
Member Author

I should have mentioned above, this addresses OpenTreeOfLife/peyotl#155

@jimallman
Copy link
Member Author

Closing this after self-assignment.

@jimallman jimallman closed this Oct 6, 2016
@jimallman
Copy link
Member Author

Note that we've decided on a more restrictive approach that

  • coerces DOIs to URLs on input (in the curation app), and
  • strictly validates incoming amendments for this (in peyotl)

So these changes (and the underlying peyotl mods) are no longer desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant