-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coerce DOI to URL in amendment file #155
Comments
This is done when fetching, adding, or updating a taxonomic amendment via the API (so it "repairs" old amendments on the fly). Addresses #155.
I have changed my mind. I think the coercion is better done in the curator app. This is just one among many possible type or structure coercions, and I don't think the back end is the place to be doing such DWIMish things. It would be a slippery slope and would make the interface spec quite complicated. But they're fine in the curator app, which is responsible for preparing documents in a form suitable for storage. If validation fails, e.g. if a field requiring a URL doesn't contain a URL, the document shouldn't be stored. Sorry to have led you astray. |
This replaces the prior fixes in peyotl. Addresses OpenTreeOfLife/peyotl#155.
I see:
Just as everywhere else in the system, the DOI should be coerced to a URL:
This could be done in the curator app, but we get more leverage if it's done in phylesystem-api or peyotl.
The text was updated successfully, but these errors were encountered: