Smarter collection refresh #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mainly preparation for the next steps: to update all metadata properties in each refreshed tree, and to mark as MODIFIED if any of them has changed since last check.
When "refreshing" a tree collection, we check its listed trees against the matching trees and studies in phylesystem, specifically any properties that are also stored in a tree collection. If *any* of these properties have changed, update our listed tree and mark it as MODIFIED. Offer these changes to a human curator, as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When refreshing/updating trees in a collection, we now compare all the study+tree properties that are stored in the tree collection to the latest study+tree in phylesystem. If any of these properties have changed, the tree is marked as MODIFIED (formerly RENAMED) for curator approval. Of course, saving the changes should store the new values in each case. Addresses #1300.
This is tested and working (afaict) on devtree.