Use a simpler scheme for safe element IDs #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed, we'd like to have single- or double-digit IDs for elements (esp. trees). This scheme will keep track of the highest minted IDs for each element type and store it in phylesystem.
|
I'm still testing this on devtree, so holding it in draft mode for now. |
This is important for old/existing studies that have not previously stashed the last-minted ID for each element type.
|
OK, this seems to be working as intended on devtree. Studies now save with accurate highest-minted-id information, reload properly, and skip any minted-then-deleted IDs. Done, I think. |
|
See the history of study tt_266 for a series of test commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, we'd like to have single- or double-digit IDs for elements (esp. trees). This scheme will keep track of the highest minted IDs for each element type and store it in phylesystem. Addresses #1302.