Feature/reorganize top bar #33
Conversation
| <Menu.Item | ||
| key={item.componentID} | ||
| leftSection={item.icon?.(IconSize.xs)} | ||
| onClick={() => { |
There was a problem hiding this comment.
Consider making this a function in the component body so it won't trigger a re-render
There was a problem hiding this comment.
I don't follow, this does not trigger a new render?
| className={'ToggleTaskBarItem'} | ||
| label={item.title} | ||
| labelPosition={'left'} | ||
| defaultChecked={checkedMenuItems[item.componentID]} |
There was a problem hiding this comment.
I don't understand the checkedMenuItems... isn't it always true for all items?
There was a problem hiding this comment.
No, things like FlightController and Keyboard panels are off by default
Maybe some mantine bug with nested menus :'( |
|
|
||
| function toggleShutdown() { | ||
| return modals.openConfirmModal({ | ||
| title: 'Confirm action', |
There was a problem hiding this comment.
Love the addition of the modal! Not 100% sure what I think of this title, though... But I don't have any better suggestion on the top of my head 🙃
Organize top bar based on our discussion, tabbing in the top menu bar now works as expected. There is visual bug when tabbing through
ViewwhereTask Baris being highlighted even though you are tabbed to one of the other menu items. Not sure whats up with that 😞