Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change restrictor for Orgaadmin #4382

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

Elblinator
Copy link
Member

@Elblinator Elblinator commented Nov 21, 2024

closes #4380

You need OpenSlides/openslides-autoupdate-service#1053 merged now use main
OpenSlides/openslides-backend#2744

Additional wanted:
An Orgaadmin should only be allowed to delete and dublicate a meeting if they have the "meeting.can_manage_settings" from this meeting

This PR is allowing an orgaadmin to see every data, option etc. if they should be able to see it. To give an Orga admin the possibility to use all action the backend needs to be changed as well

@Elblinator Elblinator added this to the 4.2 milestone Nov 21, 2024
@Elblinator Elblinator marked this pull request as ready for review November 21, 2024 16:52
@Elblinator Elblinator force-pushed the 4380-restrictor-change branch from 7b6721d to 2ede1f4 Compare November 21, 2024 16:58
@Elblinator
Copy link
Member Author

Elblinator commented Nov 25, 2024

A-E is not wanted for the Orgaadmin

An Orgadmin should not be able to delete meetings if the meeting is locked from inside and an Orgaadmin should not be able to dublicate a meeting which is locked from inside
(removed from the first comment
A) Saml options are not displayed for the Orgaadmin
B) Impressum "Check datastore" and "Thoroughly check datastore (unsafe)"
C) Meeting edit > Settings for Jitsi domain
D) Committee list > meeting import
E) Meeting export

@Elblinator
Copy link
Member Author

The PR still needs to make sure that locked meetings are displayed correctly

From a Comment from the backend:
An Orgaadmin should only be allowed to delete and dublicate a meeting if they have the "meeting.can_manage_settings" from this meeting if the meeting is locked from inside

@MSoeb MSoeb removed request for bspekker and MSoeb December 5, 2024 13:26
@Elblinator Elblinator force-pushed the 4380-restrictor-change branch from baec77c to 8bf12a9 Compare January 9, 2025 22:05
@Elblinator Elblinator assigned bastianjoel and bspekker and unassigned Elblinator Jan 9, 2025
@Elblinator Elblinator assigned bspekker and MSoeb and unassigned Elblinator Jan 13, 2025
@Elblinator Elblinator requested review from MSoeb and bastianjoel and removed request for bspekker January 13, 2025 14:11
Copy link
Member

@bastianjoel bastianjoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the cd stuff. Rest is okay now.

Copy link

@MSoeb MSoeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some permission issues:

  • Committee menu: Create a meeting is not possible. Orgaadmin needs to be committee admin to create a committee. Following the superadmin permissions, this should be possible without setting the orgaadmin as committee admin.
    image

  • Committe menu > meeting edit: Edit is not possible. Wanted behavior: Same as above.
    image

  • Meeting > Participants > Add or edit a user: Adding or editing a participant doesn't work. Permission is missing. Wanted behavior: Should work, without being a part (admin) of the meeting.
    image

  • Motions > create a motion: Didn't work if the submitter is a new participant. This is a follow up of the previous point. I assume, that this behavior will happen on every action that requires to add or edit a participant. Wanted behavior: Creating a motionwithout being part of the meeting should be possible. Just like superadmins can do it.
    image

@MSoeb MSoeb assigned Elblinator and unassigned MSoeb Jan 22, 2025
@Elblinator Elblinator assigned MSoeb and unassigned Elblinator Jan 22, 2025
@Elblinator
Copy link
Member Author

Please state your oroblem with the client, thiese are all issues with the backend

@Elblinator Elblinator requested a review from MSoeb January 22, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restriction change for Orgaadmin
4 participants