-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import Pages - csv example file improvement #4048
base: main
Are you sure you want to change the base?
Import Pages - csv example file improvement #4048
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With custom translations it is possible to get a non injective set of genders. Therefore it might not be a good idea to allow users to use this. Especially with #4027 this will get much more complicated.
For groups this is a bit different. Those are translated in the backend and therefore guaranteed to be unique. Still the meetings language instead of the users language needs to be used there but I think it might be even better to use an actually existing group name from the groups repo.
@MSoeb please provide feedback on what you want here.
Talked to @MSoeb: We do not want client side translations for genders in the example file. For groups the group name exisiting in the groups repo is the correct value to use. |
...s/pages/participants/export/participant-csv-export.service/participant-csv-export.service.ts
Outdated
Show resolved
Hide resolved
...s/pages/participants/export/participant-csv-export.service/participant-csv-export.service.ts
Outdated
Show resolved
Hide resolved
.../pages/organization/pages/accounts/services/account-export.service/account-export.service.ts
Outdated
Show resolved
Hide resolved
...s/pages/participant-import/services/participant-import.service/participant-import.service.ts
Outdated
Show resolved
Hide resolved
a0968e5
to
0ae272e
Compare
As we discussed with @rrenkert, when the custom gender feature is finalized, I'm going to extend the export files with the gender option from the organization repo. Until then the issue should remain open. |
Ah @vkrasnovyd you need to assign @bastianjoel , if you want his review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small remarks. Please wait for @bastianjoel review.
...s/pages/participants/export/participant-csv-export.service/participant-csv-export.service.ts
Outdated
Show resolved
Hide resolved
...s/pages/participants/export/participant-csv-export.service/participant-csv-export.service.ts
Outdated
Show resolved
Hide resolved
...s/pages/participants/export/participant-csv-export.service/participant-csv-export.service.ts
Outdated
Show resolved
Hide resolved
Thanks. I may still need to add a couple more changes based on your custom gender implementation. So until it's finalized, I'll keep it assigned to myself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small adjustment needed:
- Participant csv: The value for the 'new' column 'locked_out' is currently 'false'. This should be changed to value '0' to fit more the other attributes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@@ -32,7 +32,8 @@ export const getOrganizationSubscriptionConfig: SubscriptionConfigGenerator = () | |||
additionalFields: [`committee_ids`, `organization_tag_ids`], | |||
follow: [ | |||
{ idField: `mediafile_ids`, fieldset: `organizationDetail` }, | |||
{ idField: `theme_id`, fieldset: DEFAULT_FIELDSET } | |||
{ idField: `theme_id`, fieldset: DEFAULT_FIELDSET }, | |||
{ idField: `gender_ids`, fieldset: [`name`] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to subscribe this on the account/participant list.
Resolves #3822
Notes in case at some stage example files are updated again: