Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix meeting.clone list election behaviour #2791

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix meeting.clone list election behaviour #2791

wants to merge 3 commits into from

Conversation

luisa-beerboom
Copy link
Member

Closes #2783

@luisa-beerboom luisa-beerboom added this to the 4.3 milestone Jan 8, 2025
hjanott
hjanott requested changes Jan 8, 2025
View reviewed changes
tests/system/action/base.py
Comment on lines +181 to +182
"motion_state_ids": [1],
"motion_workflow_ids": [1],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use base instead of 1.

tests/system/action/meeting/test_clone.py
self.create_user("Louie", [3])
self.set_models(
{
"user/4": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Order by user id would be nicer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjanott hjanott hjanott requested changes

@Elblinator Elblinator Awaiting requested review from Elblinator

Requested changes must be addressed to merge this pull request.

Assignees

@hjanott hjanott

@Elblinator Elblinator

Labels
bug
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Fix meeting clone
3 participants
@luisa-beerboom @hjanott @Elblinator