Make systemdunitproperty probe test more independent #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current test of the `systemdunitproperty` probe is relying on the assumption that the `systemd-journald.service` unit doesn't have the `Conflicts` property set. In Rawhide, this assumption is no longer true, because `Conflicts` is now set to `soft-reboot.target` by default. This change breaks our test. In this commit, we will make the test less dependent on actual property value. Instead, we will check a dummy property that is unlikely to occur. Fixes: OpenSCAP#2066
|
/packit retest-failed |
1 similar comment
|
/packit retest-failed |
matusmarhefka
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current test of the
systemdunitpropertyprobe is relying on the assumption that thesystemd-journald.serviceunit doesn't have theConflictsproperty set. In Rawhide, this assumption is no longer true, becauseConflictsis now set tosoft-reboot.targetby default. This change breaks our test. In this commit, we will make the test less dependent on actual property value. Instead, we will check a dummy property that is unlikely to occur.Fixes: #2066