Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removal of imp module in Python 3.12 #2048

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

evgenyz
Copy link
Contributor

@evgenyz evgenyz commented Nov 7, 2023

Python 3.12 got imp module removed: https://docs.python.org/3/whatsnew/3.12.html#imp

The workaround is based on importlib module. Python 2 branch is removed because we don't care about Python 2 anymore.

@jan-cerny
Copy link
Member

/packit retest-failed

@jan-cerny jan-cerny self-assigned this Nov 7, 2023
@jan-cerny jan-cerny added this to the 1.3.10 milestone Nov 7, 2023
swig/openscap_api.py Outdated Show resolved Hide resolved
@OpenSCAP OpenSCAP deleted a comment from pep8speaks Nov 7, 2023
Copy link
Member

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI fail on Rawhide

238/277 Test #238: probes/sysctl/test_sysctl_probe_all.sh .............................................***Failed    0.29 sec
Result file: test_sysctl_probe_all.res.out.5fl6Id
Our names file: test_sysctl_probe_all.our.out.nnyTvH
Sysctl names file: test_sysctl_probe_all.sysctl.out.bTJnYG
Errors file: test_sysctl_probe_all.err.out.Ygjjz9
Diff (sysctlNames / ourNames): ------
152d151
< kernel.sched_energy_aware

isn't caused by the contents of this PR because this PR is only related to SWIG. It's probably caused by update in kernel as we saw in past.

@jan-cerny jan-cerny merged commit 30c8c39 into OpenSCAP:maint-1.3 Nov 7, 2023
18 of 19 checks passed
@jan-cerny
Copy link
Member

I have reported the problem to upstream in #2049

@evgenyz evgenyz deleted the fix-python-imp branch November 7, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants