Fix incorrect expressions reported by Coverity #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0intro
force-pushed
the
coverity-incorrect-expressions-20230920
branch
from
09a532b to
4a6c82f
Compare
jan-cerny
reviewed
Sep 25, 2023
| @@ -74,7 +74,7 @@ int64_t strto_int64 (const char *str, size_t len, char **endptr, int base) | |||
| { | |||
| int errno_copy = 0; | |||
| int64_t result = 0; | |||
| char *null_str = calloc(len + 1, sizeof(str)); | |||
| char *null_str = calloc(len + 1, sizeof(*str)); | |||
There was a problem hiding this comment.
I think it would be easier and more redable to just use malloc() here than using sizeof on a const char.
There was a problem hiding this comment.
We could use malloc, but I think, in this case, we should also call memset so the string would be null terminated.
jan-cerny
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes incorrect expressions reported by Coverity.