Merge pull request #2033 from 0intro/coverity-deadlocks-20230920

Fix deadlocks reported by Coverity

src/OVAL/probes/SEAP/seap-packetq.c

@@ -117,9 +117,11 @@ int SEAP_packetq_put(SEAP_packetq_t *queue, SEAP_packet_t *packet)
 		queue->last  = queue->first;
 	} else {
 		if (queue->last == NULL) {
-			return -1; /* XXX: unlock */
+			pthread_mutex_unlock(&queue->lock);
+			return -1;
 		}
 		if (queue->last->next != NULL) {
+			pthread_mutex_unlock(&queue->lock);
 			return -1;
 		}
 

src/OVAL/probes/probe/icache.c

@@ -214,6 +214,7 @@ const char* thread_name = "icache_worker";
 
         while(pthread_cond_wait(&cache->queue_notempty, &cache->queue_mutex) == 0) {
 			if (cache->queue_cnt <= 0) {
+				pthread_mutex_unlock(&cache->queue_mutex);
 				return NULL;
 			}
         do {
@@ -234,6 +235,7 @@ const char* thread_name = "icache_worker";
 		if (cache->queue_cnt == 0 ?
 			cache->queue_end != cache->queue_beg :
 			cache->queue_end == cache->queue_beg) {
+			pthread_mutex_unlock(&cache->queue_mutex);
 			return NULL;
 		}
 
@@ -412,6 +414,7 @@ int probe_icache_add(probe_icache_t *cache, SEXP_t *cobj, SEXP_t *item)
         if (pthread_cond_signal(&cache->queue_notempty) != 0) {
                 dE("An error ocured while signaling the `notempty' condition: %u, %s",
                    errno, strerror(errno));
+                pthread_mutex_unlock(&cache->queue_mutex);
                 return (-1);
         }
 
@@ -442,6 +445,7 @@ int probe_icache_nop(probe_icache_t *cache)
         if (pthread_cond_init(&cond, NULL) != 0) {
                 dE("Can't initialize icache queue condition variable (NOP): %u, %s",
                    errno, strerror(errno));
+                pthread_mutex_unlock(&cache->queue_mutex);
                 return (-1);
         }
 
@@ -463,6 +467,7 @@ int probe_icache_nop(probe_icache_t *cache)
                    errno, strerror(errno));
 
                 pthread_cond_destroy(&cond);
+                pthread_mutex_unlock(&cache->queue_mutex);
                 return (-1);
         }